clarified instructions

[benkoshy]

add instructions to save future users a lot of time and frustration when looking for the icon.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[benkoshy]

I signed it!

[googlebot]

CLAs look good, thanks!

[rikotacards]

Would like to add a comment to "clarifying instructions". I think there's a whole chunk missing about creating helper functions for the script file "Helper.gs". This leads to "getReceivedDate(message)" to be undefined.

However the instructions asks us to refresh the add-on before the tutorial talks about what helper functions need to be built.

Step 4, Accessing Email Messages ends with "Finally, you can implement the four functions in Helpers.gs that get called by getContextualAddOn to determine the prefilled values on the form. For now, functions only need to return the string "TODO.""

Helper functions were never included in this walk-through.

[benkoshy]

@rikotacards Sure! feel free to make a pull request to to the documentation. I can't comment on that because I don't know what is going on there.

[erickoledadevrel]

My apologies for the embarrassingly slow reply to this PR. As far as I can tell, the display density in Gmail doesn't have any effect on the sidebar. Can you explain what problem you were seeing before you changed the density and how it fixed it?

[benkoshy]

Hi @erickoledadevrel

From memory, the purpose of this PR was to improve the documentation especially where to click. When I was working through the the labs, I could not find the Icon. A picture is worth a thousand words, so I added a screenshot with instructions on where to click.

Here is the screendump showing where users should click: https://github.com/BKSpurgeon/gmail-add-ons/blob/patch-1/Step-4/changeSettings.png

As far as I can tell, the display density in Gmail doesn't have any effect on the sidebar.

I unfortunately don't really remember the problem when i was working through it to be able to make an educated comment. As a general policy, if I can follow the boy-scout rule, of leaving something in a better state than when I found it, I do that. All I can say was that that the above solution worked for me.

regards Ben