unity-jar-resolver icon indicating copy to clipboard operation
unity-jar-resolver copied to clipboard

Is it possible to point pod installation to a git branch, commit or tag

Open vegaro opened this issue 2 years ago • 6 comments

Is it possible to point the pod to a git branch, version or commit, like instructed in the official Cocoapods docs https://guides.cocoapods.org/using/the-podfile.html#from-a-podspec-in-the-root-of-a-library-repo

We would like to build a version of our Unity plugin pointing to a specific branch of our iOS pod, without having to release a new version of the pod, or create a new pod, but we don't think it's possible.

vegaro avatar Jan 25 '22 19:01 vegaro

This issue does not seem to follow the issue template. Make sure you provide all the required information.

google-oss-bot avatar Jan 25 '22 19:01 google-oss-bot

Hi @vegaro,

I don't quite know how to answer your question yet, but I see that you have provided a use case for your scenario. Could you elaborate how the resolver would be involved in your process?

paulinon avatar Jan 26 '22 17:01 paulinon

We have a unity plugin that has some iOS and Android dependencies. We use EDM4U to handle these dependencies.

We wanted to do a private release for one of our customers. This private release involved updating the iOS dependency. We didn't want to release a new version of the pod, or create a new pod just for this. Ideally we would have created a new branch in our repository (or a tag) with these changes, without releasing a new pod. Cocoapods supports pointing to a commit, branch or tag, so it's technically possible to have the podfile of a project point at this modified dependency, but since the podfile is autogenerated by EDM4U, and EDM4U doesn't allow to point to a commit, branch or tag, we have to release a new version of the pod.

vegaro avatar Jan 31 '22 20:01 vegaro

Thanks for the additional context, @vegaro. Unity generates an Xcode project when building for iOS, so a scenario like this could be possible. After modifying your Podfile so that your pod points to the desired git branch, run the following:

pod repo update pod install

I look forward to your results.

paulinon avatar Feb 02 '22 18:02 paulinon

I see. :git and :tag are not currently supported in EDM4U. Here are a list of pod attributes we support at the moment.

Should not be too difficult to add actually. Should be similar to this https://github.com/googlesamples/unity-jar-resolver/commit/f759cd3d469f4e08c5305e2ae9d41f058b5f4c37.

BTW, are you planning to use Dependencies.xml? Or do you want to specify this programmatically using AddPod()?

Feel free to send us a PR. Or we will need to schedule some time in the future for this feature request.

Shawn

chkuang-g avatar Feb 02 '22 23:02 chkuang-g

I needed this feature as well. I tried with source tag but it didn't work either

   <iosPod name="my-custom-library">
      <sources>
        <source>https://github.com/foo/bar.git</source>
      </sources>
    </iosPod>

Should sources tag work properly or do we need really need to implement git="...." property?

Edit: Oh now I get it. sources is for pod specs, not the for the source of a specific pod

cihadturhan avatar Jun 02 '22 11:06 cihadturhan