mlkit icon indicating copy to clipboard operation
mlkit copied to clipboard

Request for Swift Package Manager support

Open yujinqiu opened this issue 4 years ago • 17 comments

yujinqiu avatar Nov 17 '20 10:11 yujinqiu

Is there any news with SPM support? We have problems on M1 macs

stepan-votava avatar Mar 30 '21 11:03 stepan-votava

While Firebase is getting closer and closer to have full SPM support, is there any estimates on this one? It's a huge blocker for M1 macbooks.

kristohear avatar Apr 22 '21 20:04 kristohear

We need SPM support !

nilsnilsnils avatar Apr 29 '21 08:04 nilsnilsnils

+1 for SPM

AngryDuckFTW avatar Apr 29 '21 15:04 AngryDuckFTW

@nilsnilsnils @AngryDuckFTW there is a topic here https://issuetracker.google.com/issues/174418229 , about MLKit SPM support, I think this repository is not checked as actively as this issuetracker topic there.

kristohear avatar Apr 29 '21 16:04 kristohear

1 year has passed and M1 Pro/Max have released, but SPM is still on the way. :-(

yujinqiu avatar Nov 19 '21 08:11 yujinqiu

does it support now?>>

fukemy avatar Nov 27 '21 10:11 fukemy

Due to necessary internal infra is still being developed, we cannot add the SPM support yet.

bcdj avatar Dec 07 '21 03:12 bcdj

+1

alexis-ag avatar Dec 08 '21 13:12 alexis-ag

Hi everyone (@yujinqiu @stepan-votava @kristohear @nilsnilsnils @AngryDuckFTW @fukemy @alexis-ag): To help us gauge the importance of supporting Swift Package Manager, could you share the size of your user base? And if you can also provide an App Store link to your app, that would be helpful too. In addition, are you able to use Cocoapods version of ML Kit in place of Swift Package Manager when building your app? Will the lack of Swift Package Manager support block your development entirely?

bcdj avatar Dec 14 '21 07:12 bcdj

+1. We intentionally moved away from Cocoapods to SPM two years ago in our project, I'm sad to hear that this great lib doesn't support SPM while looking for candidates.

Frankatvend avatar Dec 20 '21 22:12 Frankatvend

@bcdj SPM is the currently recommended, and future-dominant method of managing dependencies. It's first-party and relatively mature. It seems inevitable that MLKit will need to migrate, and by waiting you discourage adoption in new projects (mixing dep. management is messy and occasionally quite frustrating)

So non-blocking, but high-misery.

Current userbase: 50-100k mau, SPM app https://greg.app/ Previous userbase: Tinder, 50-100m mau, recently (2021) migrated SPM app

codeslaw avatar Dec 28 '21 21:12 codeslaw

Not supporting SPM and M1 machines is preventing us from adopting this package in our app. We'll likely work with other partners to provide the capability we're missing.

Obviously this is free so I understand if it's not a priority, but we'd love to use it.

The usage would be for internal, non-public facing apps. So low userbase, but business critical.

garriguv avatar Feb 24 '22 08:02 garriguv

@bcdj Here's some information I hope will help:

  1. App currently in development; No user base available
  2. The CocoaPods version of ML Kit is available. pod install works, but the compiler throws a bunch of errors when building for simulator. I'll attach them below.
  3. Building works when building for a real device, so it doesn't block development entirely. But this is still a major flaw since everything needs to be run on the device. Xcode features including Live Preview do not work.

Apple Silicon is the future of all macs. Many developers are migrating to M1 macs thanks to their performance and power efficiency. Now that the transition to Apple Silicon is almost done, ML Kit will have to migrate to SPM soon.

These are the errors: Screen Shot 2022-04-13 at 8 27 23 PM

lee-jongwoo avatar Apr 13 '22 11:04 lee-jongwoo

Can you please tell me if you have a timeline or roadmap to release xcframework for this great library? Our team is waiting for you. If you need help, then let me know.

anatoliykant avatar Apr 22 '22 12:04 anatoliykant

I have successfully created MLKit's XCFramework using CocoaPods build artifacts and resolved the dependencies. https://github.com/d-date/google-mlkit-swiftpm

However, I am unable to run it on iOS devices due to Dynamic Framework or code signing issues. If anyone has a solution, please send me a pull request.

For MLKit team, please distribute your frameworks in ARM Mac (M1/M2) first to include arm64 iphonesimulator as Firebase team (@paulb777) done.

d-date avatar Aug 15 '22 15:08 d-date

However, I am unable to run it on iOS devices due to Dynamic Framework or code signing issues. If anyone has a solution, please send me a pull request.

Resolved! Now you can use MLKit in SwiftPM!

d-date avatar Aug 15 '22 18:08 d-date

Unfortunately, I found some missing internal APIs. If you know about it, please let me know where is located. https://github.com/d-date/google-mlkit-swiftpm/issues/16

d-date avatar Oct 09 '22 05:10 d-date

Unfortunately, I found some missing internal APIs. If you know about it, please let me know where is located. d-date/google-mlkit-swiftpm#16

Resolved: https://github.com/d-date/google-mlkit-swiftpm/issues/16#issuecomment-1274210156

d-date avatar Oct 11 '22 07:10 d-date

Hey guys! Any news/updates? Thanks.

alexanderkhitev avatar Oct 26 '22 20:10 alexanderkhitev

Unfortunately this won't be planned in the future release.

miworking3 avatar Nov 01 '22 18:11 miworking3

Unfortunately this won't be planned in the future release.

So google plan is.... just not planning on supporting devs with a modern arm macbook... sounds like a good plan. What a joke.

luca992 avatar Nov 01 '22 23:11 luca992

Really disappointed. Google MLKit might be sunset iOS support.

d-date avatar Nov 02 '22 00:11 d-date

Any update on that?

I'm unable to move Firebase to SPM because Google's MLKit doesn't support it. Here's an article that describes how to move to Apple's ML libraries instead to fix the problem:

https://medium.com/@fredadda/ios-strategies-to-transition-to-swift-package-manager-7d954c8abd36

If this doesn't get resolved soon, I will also drop Google's MLKit.

akirmse avatar Dec 19 '22 22:12 akirmse

any update ?

X901 avatar Jan 22 '23 20:01 X901

Cocoapods is deprecated, so if MLKit is to continue on iOS, it really needs to support SPM. SPM now has everything you need, including full ObjC support, binary support, resource support etc. I recently converted my legacy objc framework, and it all worked out.

drewmccormack avatar Feb 06 '23 09:02 drewmccormack

more than 2 years, still Google don't want to suppourt SPM !

X901 avatar Feb 13 '23 21:02 X901

mlkit not work with firebase and admob in spm, app crash

Vlastelin1 avatar Mar 28 '23 06:03 Vlastelin1

When will MLKit support SPM?

Karllas avatar Apr 17 '23 08:04 Karllas