android-testdpc icon indicating copy to clipboard operation
android-testdpc copied to clipboard

document source of mystery setup lib AARs

Open eighthave opened this issue 2 years ago • 2 comments

This project is listed as having an Apache-2.0 license. The last release (v8.0.1) included a binary lib app/libs/setup-wizard-lib-platform-release.aar. master includes three:

  • lib/setupcompat.aar
  • lib/setupdesign.aar
  • lib/strings.aar

The only documentation I could find about what these are and where they came from is from a commit message:

Use the setup wizard library from AOSP.

There are two build variants of setup wizard library available. platformRelease: minSdkVersion 21 icsCompatRelease: minSdkVersion 14 Since TestDPC is not expected to run on pre-L, platformRelease will work just fine.

Bug: 24534771 Change-Id: I3b8554a408f78ea391ce6f0d536ea6a8c16d6798

Something about the repo used (is it https://android.googlesource.com/platform/frameworks/opt/setupwizard/?) and tag/branch built would be very helpful to ensure that this app is actually all Apache-2.0 licensed.

eighthave avatar Sep 08 '22 20:09 eighthave

Setupcompat built from https://cs.android.com/android/platform/superproject/+/master:external/setupcompat/Android.bp;l=68 Setupdsign and strings built from https://cs.android.com/android/platform/superproject/+/master:external/setupdesign/Android.bp;l=28

I'll add the information to a readme alongside the aars

jscott1989 avatar Sep 12 '22 12:09 jscott1989

Sounds good! Do you have a link to the source that belongs to app/libs/setup-wizard-lib-platform-release.aar? I'd like to try building that now, since that's what's used in the latest release.

eighthave avatar Sep 22 '22 18:09 eighthave

Sorry which file? I don't see that...

I've had some issues with the prebuilts recently so thinking of mirroring the code from AOSP in here then I can directly depend on it - that should deal with your issue too

jscott1989 avatar Dec 08 '22 08:12 jscott1989

This is the file: https://github.com/googlesamples/android-testdpc/commits/master/app/libs/setup-wizard-lib-platform-release.aar

It is used in the release that is currently up on https://play.google.com/store/apps/details?id=com.afwsamples.testdpc

eighthave avatar Dec 08 '22 10:12 eighthave

Oh sorry I don't know as that predates me. I assume it's just a previous library which became setupcompat/etc.

jscott1989 avatar Dec 08 '22 11:12 jscott1989

Ok, any way to find out from previous maintainers? Or are you planning a new release soon?

eighthave avatar Dec 08 '22 12:12 eighthave

We'll be releasing as soon as we can get our release pipeline moving again - but right now our Android framework deadlines are the priority so it's been pretty delayed.

When we release it will match the current state of the github code though.

jscott1989 avatar Dec 08 '22 13:12 jscott1989

The new v9.0.1 currently on the Play Store doesn't depends anymore on setup-wizard-lib-platform-release.aar

pfmaggi avatar Nov 23 '23 14:11 pfmaggi