functionsimsearch icon indicating copy to clipboard operation
functionsimsearch copied to clipboard

Avoid adding functions of same name to the repulsion dataset

Open MohamadMansouri opened this issue 6 years ago • 3 comments

This was discussed here https://github.com/googleprojectzero/functionsimsearch/issues/17

Note: I am using the shell to do base64 decoding, I did this since I saw you reporting some problems with the python base64 method. This is costing some time. If the decoder of the base64 python3 library doesn't have such problems lets use it instead.

MohamadMansouri avatar Dec 28 '18 00:12 MohamadMansouri

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Dec 28 '18 00:12 googlebot

I signed it!

MohamadMansouri avatar Dec 28 '18 01:12 MohamadMansouri

CLAs look good, thanks!

googlebot avatar Dec 28 '18 01:12 googlebot