js-route-optimization-app icon indicating copy to clipboard operation
js-route-optimization-app copied to clipboard

Published 20 hours ago • verified publisher icon googlemaps

Style theater

Open bshi opened this issue 1 year ago • 1 comments

This repository is set up to "Squash Merge" and has a "Conventional Commit" presubmit check to enforce a style of commit message.

But "Squash Merge" obliterates the commit messages that "Conventional Commit" tries to enforce. Instead the Pull Request content is used - so people submitting pull requests are forced to do throw-away work.

https://lore.kernel.org/lkml/CAHk-=wjbtip559HcMG9VQLGPmkurh5Kc50y5BceL8Q8=aL0H3Q@mail.gmail.com/

This repository needs to be on a "Rebase" workflow for the "Conventional Commit" presubmit check to provide any added value. Or we should disable the conventional commits presubmit because it's not actually enforcing anything.

bshi avatar Sep 10 '24 20:09 bshi