js-markerclusterer icon indicating copy to clipboard operation
js-markerclusterer copied to clipboard

Change fast-deep-equal to a ESM Library

Open faragos opened this issue 2 years ago • 6 comments

Is your feature request related to a problem? Please describe. When i build my Angular project there is a warning about fast-deep-equal because it is a commonJS/AMD module whcih can't be optimized correctly

/@googlemaps/markerclusterer/dist/index.esm.js depends on 'fast-deep-equal'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Describe the solution you'd like Change the library to a ESM one or implement it in a native way.

Describe alternatives you've considered Waiting until the library supports ESM. But this doesn't look like it will happen, because the Pull Request is already open for over a year.

https://github.com/epoberezkin/fast-deep-equal/pull/105

faragos avatar May 11 '23 13:05 faragos

If you would like to upvote the priority of this issue, please comment below or react with :+1: so we can see what is popular when we triage.

@faragos Thank you for opening this issue. 🙏 Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

wangela avatar May 11 '23 13:05 wangela

Hi @wangela, should the 👍 be placed on your automated comment, or the original issue description from @faragos ?

felixranesberger avatar Jul 17 '23 10:07 felixranesberger

@felixranesberger the original description, since GitHub issue sorting looks at the count of emojis on the first comment only. I'll update the automated template! Thanks for calling my attention to the high number of votes on the automated comment.

wangela avatar Jul 18 '23 23:07 wangela

+1 here, as well. Using rollup with @open-wc/building-rollup.

twitchax avatar Nov 07 '23 01:11 twitchax

Any update on the status of this?

JshGrn avatar Jan 04 '24 10:01 JshGrn