google-maps-services-python icon indicating copy to clipboard operation
google-maps-services-python copied to clipboard

fix(places): correct typo in places detail fields

Open il-santo opened this issue 1 year ago • 4 comments

Currently there is a typo in googlemaps/places.py that prevents the retrieval ot the address components array.

This commit fixes the above mentioned typo.

il-santo avatar Sep 28 '23 14:09 il-santo

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 28 '23 14:09 google-cla[bot]

CLA should pass. Why is it not doing it?

il-santo avatar Sep 29 '23 10:09 il-santo

Hello :), It seems you have trouble to sign the CLA. I don't see anything else that should prevent merging this PR. I will upvote on the issue. I also checked the documentation : https://developers.google.com/maps/documentation/places/web-service/reference/rest/v1/places?hl=en It seems many other fields should be corrected : adr_address corresponds to nothing apparently. Best regards, Laurent Lyaudet

LLyaudet avatar Jan 04 '24 15:01 LLyaudet

Hello :), It seems you have trouble to sign the CLA. I don't see anything else that should prevent merging this PR.

It simply doesn't work.

I signed the CLA several times, and it seems ok, but if I follow the procedure to rescan the PR as a first time contributor I get a 404.

il-santo avatar Jan 04 '24 16:01 il-santo