google-maps-services-java icon indicating copy to clipboard operation
google-maps-services-java copied to clipboard

fix: Add missing type administrative_area_level_6 and administrative_area_level_7

Open gpradhan27 opened this issue 1 year ago • 7 comments

This PR adds the missing AddressComponentType administrative_area_level_6 and administrative_area_level_7 - the java doc comments for enum types were copied from https://developers.google.com/maps/documentation/geocoding/requests-geocoding , hope this is the correct one.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x] Ensure the tests and linter pass
  • [x] Code coverage does not decrease (if any source code was changed)
  • [x] Appropriate docs were updated (if necessary)

Fixes #985 🦕

gpradhan27 avatar May 14 '24 15:05 gpradhan27

hi @wangela could you please review this?

gpradhan27 avatar May 17 '24 09:05 gpradhan27

@amuramoto Do we plan to integrate the changes for the additional administrative levels? cc @gpradhan27

  • administrative_area_level_6
  • administrative_area_level_7

pantelis-goku avatar Oct 17 '24 09:10 pantelis-goku

@amuramoto Do we plan to integrate the changes for the additional administrative levels? cc @gpradhan27

  • administrative_area_level_6
  • administrative_area_level_7

Unfortunately I'm not a maintainer on this repo anymore so I can't accept PRs.

amuramoto avatar Oct 17 '24 16:10 amuramoto

@amuramoto Do you happen to know who the maintainer is now? Is the project still supported?

pantelis-goku avatar Oct 17 '24 17:10 pantelis-goku

I believe that would be @wangela

amuramoto avatar Oct 17 '24 18:10 amuramoto

Thanks @amuramoto! @wangela Is this correct? If not, do you know if this client is still maintained by Google?

I believe that would be @wangela

fotag avatar Oct 22 '24 12:10 fotag

hi @wangela any update on this?

gpradhan27 avatar Jan 17 '25 09:01 gpradhan27