google-maps-services-java icon indicating copy to clipboard operation
google-maps-services-java copied to clipboard

ADMINISTRATIVE_AREA_LEVEL_6 and ADMINISTRATIVE_AREA_LEVEL_7 is missing from AddressComponentType

Open utsabn34 opened this issue 2 years ago • 4 comments

Hi Team, It looks like ADMINISTRATIVE_AREA_LEVEL_6 and ADMINISTRATIVE_AREA_LEVEL_7 is missing from AddressComponentType which is highly used for the Geocoding address component in country like Indonesia. This address component is also being returned by Google in Geocoding API. So please add this two Address Component Type in the /google-maps-services-java/blob/main/src/main/java/com/google/maps/model/AddressComponentType.java class.

Eg: https://developers-dot-devsite-v2-prod.appspot.com/maps/documentation/utils/geocoder#q%3DJl%2520%2520RT.11/RW.7%252C%2520Duri%2520Utara%252C%2520Kec.%2520Jakarta%252011270%252C%2520Indonesia

image

utsabn34 avatar Mar 01 '22 08:03 utsabn34

@utsabn34 Thank you for opening this issue. 🙏 Please check out these other resources that might be applicable:

This is an automated message, feel free to ignore.

jpoehnelt avatar Mar 01 '22 08:03 jpoehnelt

Please feel free to submit a pull request for this.

arriolac avatar Mar 01 '22 21:03 arriolac

@arriolac @jpoehnelt Any update on this ticket?

utsabn34 avatar May 09 '22 06:05 utsabn34

I've raised a PR, please take a look: https://github.com/googlemaps/google-maps-services-java/pull/932 I've just signed CLA. I don't know how to make my commit more "semantic" than it is, sorry.

jacekgajek avatar Nov 10 '23 09:11 jacekgajek