google-maps-ios-utils icon indicating copy to clipboard operation
google-maps-ios-utils copied to clipboard

feat: add support for google maps sdk v8

Open monholm opened this issue 2 years ago • 7 comments

Google Maps SDK for iOS v8.0.0 was released with no other breaking changes than freezing support for iOS 13, meaning it should be safe to support it in Google Maps iOS Utils. See v8 release notes.

I did some brief testing and experienced no issues while using Google Maps SDK for iOS v8.0.0.

monholm avatar Jun 23 '23 20:06 monholm

This looks great! @wangela, any chance this could be merged soon?

sreuter avatar Jul 06 '23 16:07 sreuter

Thanks for offering this PR, @Simon-TechForm! Would you be able to patch into #444 instead of this separate PR? There are a number of changes in that PR that raise the minimum OS appropriately to match the requirements of 8.0.

When you do that, to follow the best practice of specifying an exact version number when depending on the Maps SDK for iOS, let's specify exactly 8.0.0.

If you'd rather not patch, I don't mind doing the change myself but I want to make sure you have the opportunity to have your contribution counted in the main branch.

wangela avatar Jul 25 '23 00:07 wangela

@monholm are you able to patch into #444 ?

Thanks for offering this PR, @Simon-TechForm! Would you be able to patch into #444 instead of this separate PR? There are a number of changes in that PR that raise the minimum OS appropriately to match the requirements of 8.0.

When you do that, to follow the best practice of specifying an exact version number when depending on the Maps SDK for iOS, let's specify exactly 8.0.0.

If you'd rather not patch, I don't mind doing the change myself but I want to make sure you have the opportunity to have your contribution counted in the main branch.

wangela avatar Oct 05 '23 00:10 wangela

@wangela can you please simply merge this ? it's blocking adding support for Google-Maps above 7.2 to react-native-maps

salah-ghanim avatar Dec 24 '23 18:12 salah-ghanim

@wangela is there any plan to merge this eventually ?

salah-ghanim avatar Feb 04 '24 18:02 salah-ghanim

@wangela Hi, does this PR have a merger plan? The progress is completely lagging behind.

TrustDec avatar May 20 '24 05:05 TrustDec

Any plans merging this?

alexookah avatar Jun 28 '24 14:06 alexookah

Closing in favor of #444

wangela avatar Jul 29 '24 23:07 wangela