android-maps-utils icon indicating copy to clipboard operation
android-maps-utils copied to clipboard

Fix #384 - Show clustered markers in exact same location

Open menismu opened this issue 6 years ago • 12 comments

This pull request implements a solution for a situation where more than one marker have the exact same location (lat and lng), an issue reported in #384.

The activity ClusteringSameLocationActivity shows 5 markers in the exact same location and use this new implementation. Basically, if the user does zoom in till the maximum zoom value and touch the cluster with the markers in the same location, markers are distributed in new locations based in the default implementation of ClusterItemsDistributor interface. A new distributor can be implemented and used calling ClusterManager.setClusterItemsDistributor.

There is a potential backward compatibility break as ClusterItem interface requires now a copy method to copy the cluster item with a new location to be used to distribute the markers. It is important to keep BC compatibility I could make changes to this feature or function.

This implementation requires to implement OnClusterClickListener and OnCameraMoveListener, this means if the library consumer needs to implement those listeners, it is a requirement to call to ClusterManager.handleClickListener or ClusterManager.OnCameraMove to keep the feature working well. This could be improved also if it is required.

menismu avatar Aug 03 '17 23:08 menismu

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot avatar Aug 03 '17 23:08 googlebot

I signed it!

menismu avatar Aug 03 '17 23:08 menismu

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot avatar Aug 03 '17 23:08 googlebot

Added the second email as an alternative email in both Github and Gmail.

menismu avatar Aug 03 '17 23:08 menismu

Would love to have this merged. And for iOS too, ideally, because if on Android only the topmost marker is shown, in iOS google map utils markers blink =)

AAverin avatar Oct 03 '17 20:10 AAverin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 03 '19 06:10 stale[bot]

Closing and re-opening to try and kick-start the CLA bot...

barbeau avatar Nov 08 '19 14:11 barbeau

@googlebot

jpoehnelt avatar Nov 14 '19 16:11 jpoehnelt

This needs cla from the initial commits from [email protected].

jpoehnelt avatar Nov 14 '19 17:11 jpoehnelt

@menismu Is [email protected] your email? If so you'll need to configure this email with GitHub for Google's bot to recognize the CLA on file: https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/adding-an-email-address-to-your-github-account

barbeau avatar Nov 19 '19 14:11 barbeau

Hi @menismu . Did you have the chance to check the latest message regarding the CLA?

kikoso avatar Jan 05 '23 15:01 kikoso

Sorry we aren't able to merge this. If you can recreate the PR from an account that you're able to sign the CLA with, feel free to propose a new PR.

wangela avatar Feb 09 '23 21:02 wangela