android-maps-utils icon indicating copy to clipboard operation
android-maps-utils copied to clipboard

build(deps): bump gradle/wrapper-validation-action from 3.3.1 to 3.5.0

Open dependabot[bot] opened this issue 1 year ago • 1 comments

There is a need for the ability to build styles with multiple themes, such as light mode and dark mode. The current process is to clone the style and change every individual color, which is cumbersome and manual when there are frequent style changes. I would like to request a solution which Maputnik could edit a style using references to colors and numbers (or any type), which can be kept in a theme style sheet. Ideally, in a field using a style reference, you would still be able to edit the field as usual. However, based on the theme which is selected, it would update the reference value instead.

Then Maputnik could generate one style per theme, with the reference values in place.

Of course, this is just one possible solution to the issue, and open to discussion.

Rough example

{
  "themes": [
    {
      "name": "light",
      "label": "Light",
      "description": "A light theme for the map style.",
      "attributes": [
        {
          "name": "background",
          "type": "color",
          "default": "#f0f0f0"
        },
        {
          "name": "water",
          "type": "color",
          "default": "#cccccc"
        },
        {
          "name": "river_width",
          "type": "number",
          "default": "4"
        }
      ]
    },
    {
      "name": "dark",
      "label": "Dark",
      "description": "A dark theme for the map style.",
      "attributes": [
        {
          "name": "background",
          "type": "color",
          "default": "#000000"
        },
        {
          "name": "water",
          "type": "color",
          "default": "#333333"
        },
        {
          "name": "river_width",
          "type": "number",
          "default": "6"
        }
      ]
    }
  ]
}

Style building in Maputnik:

[
  {
    "id": "background",
    "type": "background",
    "layout": {
      "visibility": "visible"
    },
    "paint": {
      "background-color": "$water"
    }
  },
  {
    "id": "water lines",
    "type": "line",
    "source": "tile_source_42",
    "source-layer": "water_lines",
    "paint": {
      "line-color": "$water",
      "line-width": "$river_width"
    }
  }
]

dependabot[bot] avatar Jul 15 '24 23:07 dependabot[bot]

Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 38.15% :green_apple:

googlemaps-bot avatar Jul 15 '24 23:07 googlemaps-bot

Supersed by actions/wrapper-validation@v4

kikoso avatar Nov 04 '24 18:11 kikoso

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Nov 04 '24 18:11 dependabot[bot]