android-maps-compose icon indicating copy to clipboard operation
android-maps-compose copied to clipboard

chore: recomposition demo, updates Camera

Open CaolanCode opened this issue 1 year ago • 6 comments

Hello,

In the recomposition demonstration the camera position is not updated with the marker position. I have updated the camera position when the marker position is changed. I've also used the location "signapore4" as it wasn't used.

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Code coverage does not decrease (if any source code was changed)
  • [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

CaolanCode avatar Apr 03 '24 12:04 CaolanCode

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 03 '24 12:04 google-cla[bot]

I have signed the CLA

CaolanCode avatar Apr 04 '24 18:04 CaolanCode

Hello and thanks for the PR, @CaolanCode ! I have updated the title to follow the semantic PR specification. Could you please update your commit name to follow the following convention?

kikoso avatar Apr 18 '24 09:04 kikoso

Hi @CaolanCode . Did you manage to see the previous message?

kikoso avatar May 13 '24 09:05 kikoso

Hi @kikoso, thanks for the message. I've updated the sematics of the PR.

CaolanCode avatar May 13 '24 13:05 CaolanCode