android-maps-compose icon indicating copy to clipboard operation
android-maps-compose copied to clipboard

feat: Add `onClusterManager` to `Clustering` to allow easy default overrides (e.g. setting `minClusterSize`)

Open darronschall opened this issue 1 year ago • 3 comments

When using the default cluster renderer, allow callers to easily configure the minClusterSize value.

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x] Ensure the tests and linter pass
  • [x] Code coverage does not decrease (if any source code was changed)
  • [x] Appropriate docs were updated (if necessary)

Fixes #388 🦕

darronschall avatar Dec 12 '23 16:12 darronschall

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 12 '23 16:12 google-cla[bot]

I actually think it's easier to add a lambda to the current method which can look like this:

modifyDefaultClusterRenderer: (DefaultClusterRenderer) -> Unit = { }

and than users can just do whatever they want with it, so you add 1 method to the existing method and call the lambda after creating the default cluster renderer.

Jasperav avatar Dec 12 '23 16:12 Jasperav

It's been over 6 months since I initially created this PR. I noticed recently it was stale and needed conflict resolution.

I rebased and rebuilt it to simplify history. Any chance this version can get merged? It closes #388 with a minimal optional API addition.

darronschall avatar Jul 01 '24 13:07 darronschall

:tada: This PR is included in version 6.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

googlemaps-bot avatar Dec 06 '24 17:12 googlemaps-bot