android-maps-compose icon indicating copy to clipboard operation
android-maps-compose copied to clipboard

Published 20 hours ago • verified publisher icon googlemaps

fix: Set initial map padding (#326)

Open kkris opened this issue 2 years ago • 5 comments

Fixes #326 🦕

With this fix applied, the example from #326 now behaves correctly: https://github.com/googlemaps/android-maps-compose/assets/232214/7a07bcbb-c9fc-4924-8131-762926f36e29

kkris avatar Jun 12 '23 21:06 kkris

Thanks for the contribution @kkris ! This fixes the issue.

kikoso avatar Oct 13 '23 13:10 kikoso

@kikoso Thanks for reviewing! Any idea how to fix the Run instrumentation tests check?

java.lang.IllegalStateException: Maps API key not specified
	at com.google.maps.android.compose.MapInColumnTests.initMap(MapInColumnTests.kt:43)

kkris avatar Oct 26 '23 06:10 kkris

Hi @kkris ! Since you are running it from another branch, the instrumented tests are going to fail since you do not have a local API Key.

We have thought of a couple of solutions here, but nothing in place so far. What you can do in the meantime is run the instrumentation test locally.

Before merging the external contributions we run the test locally too.

kikoso avatar Oct 27 '23 15:10 kikoso

Hi @kkris . There were a couple of comments to be tackled [1],[2], would you mind taking a look? Otherwise the PR is in a mergeable state.

Thanks!.

kikoso avatar Oct 16 '24 09:10 kikoso

I rebased the branch on current main and applied the review comments.

kkris avatar Oct 18 '24 18:10 kkris

:tada: This PR is included in version 6.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

googlemaps-bot avatar Oct 29 '24 16:10 googlemaps-bot