android-maps-compose icon indicating copy to clipboard operation
android-maps-compose copied to clipboard

feat: Add StyleSpans support for Polylines

Open lenoch0d opened this issue 2 years ago • 1 comments

Fixes #307 🦕

  • updated google play maps services which support the new feature
  • added new Polyline composable with the spans parameter, allowing to specify spans for each segment of points
  • I did not extend the existing Polyline composable, because I believe it would be confusing with the color parameter - it doesn't make sense to specify it when we specify Spans for every segment. To not make it confusing, I think we'd need to make it nullable without the default color. However, that would be a braking change.

lenoch0d avatar Apr 17 '23 14:04 lenoch0d

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 17 '23 14:04 google-cla[bot]

Hi! I wanted to check in and see if you're planning to continue working on it? We're looking forward to potentially incorporating these changes into our project.

el-qq avatar Apr 08 '24 09:04 el-qq

@kikoso Could you please close the PR? (outdated)

el-qq avatar Apr 23 '24 16:04 el-qq

Done! Thanks for the reminder, @el-qq

kikoso avatar Apr 23 '24 16:04 kikoso