android-maps-compose icon indicating copy to clipboard operation
android-maps-compose copied to clipboard

Published 20 hours ago • verified publisher icon googlemaps

RFC: Remove experimental MapEffect composable

Open wangela opened this issue 2 years ago • 4 comments

If you would like to recommend against this proposal, please comment below or react with 👎 .

MapEffect was added in #140 to expose the underlying GoogleMap Maps SDK object to enable extension and usages such as clustering with the utility library.

With Compose-native clustering being added by #258, we're hoping that MapEffect is no longer needed. Providing direct access to the map is potentially buggy as noted in this comment.

It seems like MapEffect would still be necessary for other Android Maps Utils such as GeoJSON layer (#29) and KML layer (#129).

Please comment below if you have other use cases that would require exposing the map object.

wangela avatar Feb 16 '23 20:02 wangela

https://github.com/googlemaps/android-maps-compose/issues/272

Shusshu avatar Feb 20 '23 14:02 Shusshu

#282

philip-segerfast avatar Jul 04 '23 07:07 philip-segerfast

Also useful for helping with #293

wangela avatar Aug 11 '23 19:08 wangela

As others already pointed out removing MapEffect will not make possible to add any Kml or GeoJson layer to a compose map.

br00 avatar Oct 24 '23 21:10 br00