android-maps-compose icon indicating copy to clipboard operation
android-maps-compose copied to clipboard

feat: Use version catalog for dependency management

Open oas004 opened this issue 3 years ago • 3 comments

First of all, thanks for an awesome project! 🤩 I really like it!

In this PR I have tried to implement version catalog for dependency management. This is important to ensure consistency in library versions across modules.

~~There are some things to consider. The AGP version is not yet updated (7.0.4) and therefore [version catalog]~~ ~~(https://docs.gradle.org/current/userguide/platforms.html) is still experimental. However, since there was a PR on~~ ~~this (181) I thought this was okay. Then I can~~ ~~rebase and remove the enableFeaturePreview flag when that is merged. Furthermore, I have not~~ ~~implemented plugins in library.versions.toml as that is a feature that was added in version 7.2 of gradle.~~

Update: Rebased on #181, used plugins from version catalog and updated the root gradle file 😄


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x] Ensure the tests and linter pass
  • [x] Code coverage does not decrease (if any source code was changed)
  • [x] Appropriate docs were updated (if necessary)

Fixes #172 🦕 Fixes #160 🦕

oas004 avatar Jul 30 '22 22:07 oas004

@barbeau There is always one UI test that is failing, it runs green locally. Is it just a flaky test? Or is there something I can do to optimise this? 🤔 😄

oas004 avatar Aug 03 '22 17:08 oas004

@oas004 it's a known issue with the test on CI at the moment. Please see https://github.com/googlemaps/android-maps-compose/issues/174.

barbeau avatar Aug 03 '22 21:08 barbeau

@oas004 it's a known issue with the test on CI at the moment. Please see #174.

Thanks for quick reply! That makes sense! I'll leave it be then as the tests are passing locally 😄

oas004 avatar Aug 03 '22 21:08 oas004

:tada: This PR is included in version 2.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

googlemaps-bot avatar Aug 17 '22 23:08 googlemaps-bot