android-places-demos icon indicating copy to clipboard operation
android-places-demos copied to clipboard

Fix crash on autocomplete error

Open arnaud33200 opened this issue 1 year ago • 3 comments

fix a crash when there is an error result for autocompleteLauncher

Fixes #733 🦕

arnaud33200 avatar Aug 29 '24 01:08 arnaud33200

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 29 '24 01:08 google-cla[bot]

Thanks for opening this PR!

Before we merge it, could you please

  1. take a look at the Contributor License Agreement (CLA) and,

  2. take a look at the commit messages? We're using Conventional Commits to help keep our commit history organized, and it looks like this doesn't follow that format. Also, please update the PR title to have a conventional commit prefix.

Thanks again and let me know if you have any questions!

dkhawk avatar Oct 07 '24 22:10 dkhawk

Hi @arnaud33200 ! Did you have the chance to take a look at the message above? We would need you to sign the CLA, and also to rewrite the commit title/message to follow the conventional commit guidelines.

Let us know if you have any further questions, thanks!

kikoso avatar Nov 01 '24 20:11 kikoso