htsget icon indicating copy to clipboard operation
htsget copied to clipboard

Htsget BAM to implementation for file interface

Open aaliomer opened this issue 6 years ago • 6 comments

I created a file interface for htsget incase you're using a file system instead of google cloud I didn't change the previous code and I didn't add documentation for it (pretty self explanatory)

If this pull request gets accepted, I'll add modifications to the README

I'm looking into the cram implementation in the coming future

aaliomer avatar Feb 13 '19 20:02 aaliomer

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Feb 13 '19 20:02 googlebot

CLA signed

aaliomer avatar Feb 13 '19 20:02 aaliomer

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot avatar Feb 13 '19 20:02 googlebot

i'm the only one who wrote code

aaliomer avatar Feb 13 '19 20:02 aaliomer

@gkelly @deflaux @google-admin Hello guys. Can you help me with this? I signed the CLA and im the only one who made the commits

aaliomer avatar Feb 13 '19 20:02 aaliomer

@aaliomer

Thanks for reaching out. I took a look and, after discussing it with our product manager (@sheffi), this doesn't look like it really aligns with our product roadmap.

This server is intended as an implementation of HTSGET on top of Google's Cloud technologies. A local file-based implementation isn't something that we are looking to add to this product at this time.

If you need this functionality for a project of your own and would like to use our server as a foundation, I suggest keeping your changes in a fork that can be used by other people with similar problems.

Thanks, Aaron

kemp-google avatar Feb 15 '19 01:02 kemp-google