quilkin icon indicating copy to clipboard operation
quilkin copied to clipboard

Documentation has wrong image details on release

Open markmandel opened this issue 2 years ago • 0 comments

What happened:

Noticed:

  • https://googleforgames.github.io/quilkin/v0.6.0/book/installation.html
  • https://googleforgames.github.io/quilkin/v0.5.0/book/using.html

Has the image as us-docker.pkg.dev/quilkin/release/quilkin:0.6.0-92b4920 (or similar for past releases)

What you expected to happen:

Should be: us-docker.pkg.dev/quilkin/release/quilkin:0.6.0

How to reproduce it (as minimally and precisely as possible):

Look at the docs

Anything else we need to know?:

Relevant places to look:

  • https://github.com/googleforgames/quilkin/blob/main/.github/workflows/docs.yml
  • https://github.com/googleforgames/quilkin/blob/d8e93b60ab0be42d8ae7b020d21302345d6dfe7b/docs/src/installation.md?plain=1#L17C45-L17C60
  • https://github.com/googleforgames/quilkin/blob/d8e93b60ab0be42d8ae7b020d21302345d6dfe7b/build/Makefile#L31C7-L36

Should also backport the fixes to the gh-pages branch.

Environment:

  • Quilkin version: dev
  • Execution environment (binary, container, etc): n/a
  • Operating system: n/a
  • Custom filters? (Yes/No - if so, what do they do?):
  • Log(s):
  • Others:

markmandel avatar Sep 11 '23 18:09 markmandel