open-match icon indicating copy to clipboard operation
open-match copied to clipboard

Published 20 hours ago • verified publisher icon googleforgames

Add annotation settings to frontend Service helm for `aws-load-balancer-controller`

Open SpringMT opened this issue 2 years ago • 1 comments

What this PR does / Why we need it: I try to use open-match with AWS EKS. In AWS EKS, aws-load-balancer-controller is needed using AWS LB(ALB or NLB) for k8s Service. https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.3/guide/service/annotations/ Usingaws-load-balancer-controller, need some annotations for Service.

But, no annotaion options for frontend Service. https://github.com/googleforgames/open-match/blob/main/install/helm/open-match/templates/frontend.yaml#L21 .

So, add frontend.service.annotations settings for Helm.

Which issue(s) this PR fixes:

Closes #1441

Special notes for your reviewer:

SpringMT avatar Aug 23 '22 00:08 SpringMT

Thanks for submitting the PR for this!

syntxerror avatar Sep 02 '22 14:09 syntxerror

Hi @SpringMT, Could you please sign the CLA and let us know if facing any difficulty.

mridulji avatar Mar 01 '23 16:03 mridulji

I signed the CLA.

SpringMT avatar Mar 03 '23 00:03 SpringMT

Ah! I see, if you rebase your local branch to repo's main branch and then force push it then this CLA issue will be fixed.

mridulji avatar Mar 06 '23 16:03 mridulji