open-match icon indicating copy to clipboard operation
open-match copied to clipboard

Add custom annotations to Service Account

Open sierrasoleil opened this issue 2 years ago • 2 comments

What this PR does / Why we need it: This PR adds the ability to include custom annotations on the Open Match service account. My specific use case is to allow that service account to leverage Workload Identity to write logs and metrics.

sierrasoleil avatar Jun 27 '22 16:06 sierrasoleil

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 27 '22 16:06 google-cla[bot]

Hey @sierrasoleil, Could you please file an issue using applicable template to elaborate the problem faced and/or what solutions you suggest to it and mention that issue in this PR so that it will be helpful for community to understand it.

mridulji avatar Aug 05 '22 17:08 mridulji

@sierrasoleil, May I know if you are still working on it and would like to re-iterate that it would be very helpful if you file an issue explaining the problem.

mridulji avatar Aug 19 '22 02:08 mridulji

@mridulji I submitted issue 1485 to explain the change.

sierrasoleil avatar Aug 19 '22 03:08 sierrasoleil