open-match icon indicating copy to clipboard operation
open-match copied to clipboard

Published 20 hours ago • verified publisher icon googleforgames

Remove dependencies for e2e tests by creating independent go mod files.

Open syntxerror opened this issue 2 years ago • 1 comments

What happened: An issue (#1384) identified the go-client is out of date but it was identified that go-client is only used for tooling. After discussion it would be best to move all dependencies for e2e test such as go-client into a separate go mod file since Open Match does not depend of several of these.

syntxerror avatar Mar 22 '22 18:03 syntxerror

Thoughts on this issue. We should move the e2e test either to the parent directory and not part of the open match internals or out of this repo and into the ecosystem repo. Thoughts

syntxerror avatar Aug 08 '22 15:08 syntxerror

Hi @syntxerror, what's the status of this issue? I've seen the PR, but it's been open for a while now.

akmalabbasov avatar Oct 21 '22 11:10 akmalabbasov

Hey @akmalabbasov, I like to inform you that we're figuring out on its possible solution which is likely to be included in upcoming release. And we are eager to know if you want to present any thoughts of yours. Thanks 🙂

mridulji avatar Oct 21 '22 11:10 mridulji

Hi @mridulji, When I update open-match to the latest (1.5.0), k8s.io/client-go downgrades to pretty old one, which breaks everything.

go: upgraded k8s.io/client-go v0.22.5 => v11.0.1-0.20191029005444-8e4128053008+incompatible
go: upgraded open-match.dev/open-match v0.10.0 => v1.5.0

Would appreciate if we can get the changes https://github.com/googleforgames/open-match/pull/1481 or update the dependency. I can help with work if required. Thanks.

akmalabbasov avatar Oct 24 '22 07:10 akmalabbasov