open-match icon indicating copy to clipboard operation
open-match copied to clipboard

Refactor internal/config package and have it checks the necessary config values

Open yfei1 opened this issue 5 years ago • 2 comments

This issue tracks the progress on refactoring the internal/config package. Our current config package directly read the config files from viper and wont check what fields are missing at all. It would be great if we could refactor/add a tool to check what fields are missing from the config and document the default config values for the optional fields instead.

yfei1 avatar Dec 09 '19 20:12 yfei1

Would this be usage impacting? or just making Open Match more resilient to misconfigurations? If the later, we can move this to v0.10

sawagh avatar Jan 15 '20 03:01 sawagh

I can take a look at this one. @yfei1 @Laremere where can I check which values are mandatory or not? Some default value I've found here: https://open-match.dev/site/docs/installation/helm/#configuration

akremsa avatar Sep 07 '20 11:09 akremsa