googleforgames
Feat: Move SidecarContainers feature gate to Beta
Promotes the SidecarContainers feature gate from Alpha to Beta, making it enabled by default. This feature has been stable since v1.49.0 with no error reports
What type of PR is this? /kind feature
What this PR does / Why we need it: The SidecarContainers feature refactors how the SDK server runs by utilizing Kubernetes native sidecar container support, decoupling the SDK lifecycle from the GameServer container lifecycle. This feature has been in Alpha since v1.49.0 with no reported issues, indicating it is ready for broader adoption.
Which issue(s) this PR fixes: Closes #4361
Special notes for your reviewer:
- This is a breaking change for users who explicitly rely on
SidecarContainersbeing disabled by default
Build Succeeded :partying_face:
Build Id: 0254bc2d-e049-4aa8-ab8e-8e329cbb6a89
The following development artifacts have been built, and will exist for the next 30 days:
- image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-c0aa690
- image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-c0aa690
- image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-c0aa690-linux
- image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-c0aa690
- image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-c0aa690
- image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-c0aa690
- Linux C++ SDK (build): agonessdk-1.54.0-dev-c0aa690-linux-arch_64.tar.gz
- SDK Server: agonessdk-server-1.54.0-dev-c0aa690.zip
A preview of the website (the last 30 builds are retained):
- https://c0aa690-dot-preview-dot-agones-images.appspot.com/
To install this version:
git fetch https://github.com/googleforgames/agones.git pull/4364/head:pr_4364 && git checkout pr_4364
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-c0aa690
Oh, also noticed the issues with the CLA. If you look here: https://github.com/googleforgames/agones/pull/4364/checks?check_run_id=56852071285
You'll notice you have two separate commit emails for this PR, so either you need to rebase against the one account that has signed the CLA, or need to sign it again with the other email.
the other author is @lacroixthomas , his CLA should be already signed, correct??
Hi @AryanBagade
I already signed the CLA a long time ago, but it seems that when you applied the changes from my comment, it used one of my email that seems not to have the CLA signed 🤔 First time I see that
Do you mind to do a rebase (to squash the commit with my name) with your account that have signed the CLA ? This should get rid of "my" commit and pass the CLA test
Sorry about that, I'll have a look to understand why it happened
Hi @AryanBagade
I already signed the CLA a long time ago, but it seems that when you applied the changes from my comment, it used one of my email that seems not to have the CLA signed 🤔 First time I see that
Do you mind to do a rebase (to squash the commit with my name) with your account that have signed the CLA ? This should get rid of "my" commit and pass the CLA test
Sorry about that, I'll have a look to understand why it happened
oooh! That's what happened! Oopsie!
Agreed -- @AryanBagade if you pull it down locally and squash the commits and git push --force back up, that'll solve it. If you have issues let us know, since maintainers can edit this PR as well directly.
And don't stress over timing -- we release every 6 weeks, so no rush.
👋🏻 just checking in! Lemme know if you need a hand with the squashing and/or fixing the conflicts.