agones icon indicating copy to clipboard operation
agones copied to clipboard

Bump glob from 10.3.15 to 10.5.0 in /sdks/nodejs

Open dependabot[bot] opened this issue 1 month ago • 3 comments

Bumps glob from 10.3.15 to 10.5.0.

Changelog

Sourced from glob's changelog.

changeglob

12

  • Remove the unsafe --shell option. The --shell option is now ONLY supported on known shells where the behavior can be implemented safely.

11.1

GHSA-5j98-mcp5-4vw2

  • Add the --shell option for the command line, with a warning that this is unsafe. (It will be removed in v12.)
  • Add the --cmd-arg/-g as a way to safely add positional arguments to the command provided to the CLI tool.
  • Detect commands with space or quote characters on known shells, and pass positional arguments to them safely, avoiding shell:true execution.

11.0

  • Drop support for node before v20

10.4

  • Add includeChildMatches: false option
  • Export the Ignore class

10.3

  • Add --default -p flag to provide a default pattern
  • exclude symbolic links to directories when follow and nodir are both set

10.2

  • Add glob cli

10.1

  • Return '.' instead of the empty string '' when the current working directory is returned as a match.
  • Add posix: true option to return / delimited paths, even on Windows.

10.0.0

  • No default exports, only named exports

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Nov 18 '25 20:11 dependabot[bot]

Nice try @dependabot 😄 You updated the package-lock file but you most probably wanted to update the package.json dependencies right ?

Did you meant to update these dependencies ?

    "dependencies": {
        "@grpc/grpc-js": "1.14.1", // previously 1.10.9
        "google-protobuf": "4.0.1" // previously 3.21.2
    },
    "devDependencies": {
        "eslint": "^9.39.1", // previously ^8.57.0
        "jasmine": "^5.12.0", // previously ^5.1.0
        "nyc": "^17.1.0" // previously ^15.1.0
    },

glob and js-yaml are dependencies of jasmine and eslint respectively

lacroixthomas avatar Nov 19 '25 22:11 lacroixthomas

@steven-supersolid - what's the right approach here for the JS dependabot updates?

markmandel avatar Nov 19 '25 22:11 markmandel

@steven-supersolid - what's the right approach here for the JS dependabot updates?

When installing with npm install the dependencies in package-lock.json will apply provided they are considered valid in package.json. As these are transitive dependencies this will be fine because the package maintainer has set a range.

So this is fine as a security update.

The dependencies mentioned by @lacroixthomas can be updated as a manual process especially as some a major version updates to likely introduce a breaking change. This would be an maintenance task. It is only required if we want to take advantage of new features or if a security update requires a new direct dependency update. A lighter maintenance task would be to only update to the latest minor version as in theory there should be no breaking changes. Running npm update afterwards would also then update transitive dependencies to their latest allowed version. If this introduces incompatibilities then npm audit fix will only update the insecure dependencies.

steven-supersolid avatar Nov 21 '25 10:11 steven-supersolid