agones icon indicating copy to clipboard operation
agones copied to clipboard
verified publisher icon googleforgames

Fix sdkserver updatelist gameserver max items

Open Sivasankaran25 opened this issue 2 months ago • 27 comments

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup /kind documentation /kind feature /kind hotfix /kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4282

Special notes for your reviewer:

Sivasankaran25 avatar Nov 07 '25 05:11 Sivasankaran25

Build Failed :sob:

Build Id: 319cbd65-a372-4be5-a987-ec4147f8a048

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 07 '25 05:11 agones-bot

Build Failed :sob:

Build Id: 9e75dbdc-79ea-4f5e-85f4-46c2cbe69e72

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 07 '25 06:11 agones-bot

Build Failed :sob:

Build Id: e3d85ba8-6eb9-45b8-8629-aaa00ed5917b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 09 '25 18:11 agones-bot

/gcbrun

Sivasankaran25 avatar Nov 09 '25 18:11 Sivasankaran25

Build Failed :sob:

Build Id: 55b79fc1-6166-4dce-a2f3-671c82e76ef1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 09 '25 19:11 agones-bot

Build Failed :sob:

Build Id: 7e8a1900-0cef-4c8b-aeec-3f0b6c905c7e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 10 '25 07:11 agones-bot

Build Failed :sob:

Build Id: 3c1bf51b-6835-432b-9b0e-3370a9e3e2aa

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 10 '25 18:11 agones-bot

Build Failed :sob:

Build Id: b82c3e58-65be-40aa-aeff-51a8683eae02

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 10 '25 20:11 agones-bot

Build Failed :sob:

Build Id: 94b9b58d-2871-4e76-942a-2beab4801f4f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 10 '25 23:11 agones-bot

Build Succeeded :partying_face:

Build Id: e600b69e-e83c-4af2-9a6e-5b360d3c0fa0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://fab928a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-fab928a

agones-bot avatar Nov 12 '25 10:11 agones-bot

Build Failed :sob:

Build Id: d288eba9-4bdd-4227-a4bd-e662e16d0cc1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 12 '25 16:11 agones-bot

Build Failed :sob:

Build Id: 7e971c00-dd3f-4ad6-af6a-141a5c4adce1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 13 '25 04:11 agones-bot

Build Succeeded :partying_face:

Build Id: 876576c7-8707-448f-a419-f77bae7d6122

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://c6242c0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-c6242c0

agones-bot avatar Nov 13 '25 05:11 agones-bot

Build Succeeded :partying_face:

Build Id: 561799b9-af19-4fb9-be98-b0972c4c6d94

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://c37bcf2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-c37bcf2

agones-bot avatar Nov 19 '25 10:11 agones-bot

Build Succeeded :partying_face:

Build Id: 2b9a3e0b-b035-44ee-8344-4c7712c3550b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://0084be5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-0084be5

agones-bot avatar Nov 23 '25 06:11 agones-bot

Build Failed :sob:

Build Id: 8320d61a-fcd6-41aa-9e37-793aba5c5997

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 25 '25 08:11 agones-bot

/gcbrun

Sivasankaran25 avatar Nov 25 '25 08:11 Sivasankaran25

Build Failed :sob:

Build Id: d86648fb-b274-4d84-8086-ff5235d68fcf

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 25 '25 08:11 agones-bot

/gcbrun

Sivasankaran25 avatar Nov 25 '25 09:11 Sivasankaran25

Build Failed :sob:

Build Id: 3661d7e0-9751-4871-b95d-70e20fc1f178

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 25 '25 10:11 agones-bot

/gcbrun

Sivasankaran25 avatar Nov 25 '25 15:11 Sivasankaran25

Build Failed :sob:

Build Id: a28a2835-69ee-4c25-af49-56c246697668

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Nov 25 '25 16:11 agones-bot

Build Succeeded :partying_face:

Build Id: 2b38c2db-b83c-4628-a30c-3a22180a129b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://032d226-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-032d226

agones-bot avatar Nov 26 '25 06:11 agones-bot

Build Succeeded :partying_face:

Build Id: 0ad4b7d8-6d35-42ea-b28b-7514028f5378

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://7b4200e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-7b4200e

agones-bot avatar Dec 01 '25 05:12 agones-bot

Build Succeeded :partying_face:

Build Id: 2934421c-df24-4882-9fe9-12a3609a2188

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://4617415-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-4617415

agones-bot avatar Dec 02 '25 07:12 agones-bot

Build Succeeded :partying_face:

Build Id: ae326180-1d53-42b0-9505-1c7d5f815403

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://35c12f0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-35c12f0

agones-bot avatar Dec 02 '25 19:12 agones-bot

Build Succeeded :partying_face:

Build Id: a79c6800-5bc8-479f-ada5-f17e08fdbc87

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://c05c00a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-c05c00a

agones-bot avatar Dec 08 '25 05:12 agones-bot

Build Succeeded :partying_face:

Build Id: 5d65dc94-9c0f-4f2a-babc-e6173f015e94

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://6408714-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4326/head:pr_4326 && git checkout pr_4326
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-6408714

agones-bot avatar Dec 17 '25 07:12 agones-bot

Build Failed :sob:

Build Id: 57e6cd21-847a-43f9-8683-3f13a1ee51c4

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Dec 17 '25 23:12 agones-bot

Flaky unit test:

{"message":"unable to calculate 'Ready' state duration of 's2v9llhh4v1' GameServer","severity":"warning","source":"*metrics.Controller","time":"2025-12-17T23:54:54.815475533Z"}
--- FAIL: TestControllerGameServerCount (2.11s)
    controller_test.go:88: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/metrics/controller_test.go:88
        	            				/go/src/agones.dev/agones/pkg/metrics/controller_test.go:289
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 1
        	Test:       	TestControllerGameServerCount
        	Messages:   	metric: gameservers_count, tags: [{none true} {default true} {PortAllocation true}], values don't match; got: 1, want: 2
{"message":"Wait for cache sync","severity":"info","time":"2025-12-17T23:54:54.818099822Z"}

Haven't seen that one before!

/gcbrun

markmandel avatar Dec 18 '25 00:12 markmandel