agones icon indicating copy to clipboard operation
agones copied to clipboard

Define SDKServer LogLevel early

Open Kalaiselvi84 opened this issue 1 year ago • 15 comments

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking /kind bug /kind cleanup /kind documentation /kind feature /kind hotfix /kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3629

Special notes for your reviewer:

Kalaiselvi84 avatar Feb 02 '24 18:02 Kalaiselvi84

I've defined the sdkServer logLevel at the beginning of the sdk-server/main.go file. Please let me know if this is the correct approach and what are the other necessary changes required?

Kalaiselvi84 avatar Feb 02 '24 18:02 Kalaiselvi84

Build Failed :scream:

Build Id: 5f6842c0-3883-45d3-8b3f-8c9c3e4a7a85

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Feb 02 '24 18:02 agones-bot

I've defined the sdkServer logLevel at the beginning of the sdk-server/main.go file. Please let me know if this is the correct approach and what are the other necessary changes required?

To add the environment variable to the sidecar, you will need to edit this function to add an environment variable to the set that already exists: https://github.com/googleforgames/agones/blob/5f58fce4c00f97ef012db8f8a503898a4725d11b/pkg/gameservers/controller.go#L641

markmandel avatar Feb 06 '24 06:02 markmandel

Build Failed :scream:

Build Id: cabb1ae6-ad2b-4e07-bbbf-3fd75e5007a0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Feb 06 '24 22:02 agones-bot

To add the environment variable to the sidecar, you will need to edit this function to add an environment variable to the set that already exists:

I've added an environment variable to the sidecar method in the pkg/gameservers/controller.go file and updated the Run method to reflect this capture in the pkg/sdkserver/sdkserver.go file. Does this change seem correct to you? Please let me know if anything else needs to be modified.

Kalaiselvi84 avatar Feb 06 '24 22:02 Kalaiselvi84

Build Failed :scream:

Build Id: dcd467b6-3e41-46bc-8c16-9cdb2c2bed38

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Feb 06 '24 23:02 agones-bot

Build Succeeded :clap:

Build Id: 044857f0-d3fe-4edc-b250-877ecf04dc9e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://5fbabcc-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3631/head:pr_3631 && git checkout pr_3631
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-5fbabcc-amd64

agones-bot avatar Feb 07 '24 00:02 agones-bot

Build Failed :scream:

Build Id: 1369b9d8-b25e-4b05-9a01-0e4c6b8420e1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Feb 12 '24 20:02 agones-bot

Build Succeeded :clap:

Build Id: a6b36772-984b-46fe-ba64-8ad66374399a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://e3ea7a8-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3631/head:pr_3631 && git checkout pr_3631
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-e3ea7a8-amd64

agones-bot avatar Feb 12 '24 23:02 agones-bot

Build Failed :scream:

Build Id: 70b31dca-e43f-45b7-b6a3-ce00b6f2dc14

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Feb 13 '24 04:02 agones-bot

#6 34.23 Err:1 http://deb.debian.org/debian bullseye/main amd64 wget amd64 1.21-1+deb11u1
#6 34.23   Could not connect to debian.map.fastlydns.net:80 (199.232.98.132), connection timed out Unable to connect to deb.debian.org:http:
#6 34.24 E: Failed to fetch http://deb.debian.org/debian/pool/main/w/wget/wget_1.21-1%2bdeb11u1_amd64.deb  Could not connect to debian.map.fastlydns.net:80 (199.232.98.132), connection timed out Unable to connect to deb.debian.org:http:
#6 34.24 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
#6 ERROR: executor failed running [/bin/sh -c apt-get --allow-releaseinfo-change update &&     apt-get install -y wget]: exit code: 100
------
 > [2/7] RUN apt-get --allow-releaseinfo-change update &&     apt-get install -y wget:

3.917 The following NEW packages will be installed:
3.918   wget
34.23 0 upgraded, 1 newly installed, 0 to remove and 22 not upgraded.
34.23 Need to get 964 kB of archives.
34.23 After this operation, 3559 kB of additional disk space will be used.
34.23 Err:1 http://deb.debian.org/debian bullseye/main amd64 wget amd64 1.21-1+deb11u1
34.23   Could not connect to debian.map.fastlydns.net:80 (199.232.98.132), connection timed out Unable to connect to deb.debian.org:http:
34.24 E: Failed to fetch http://deb.debian.org/debian/pool/main/w/wget/wget_1.21-1%2bdeb11u1_amd64.deb  Could not connect to debian.map.fastlydns.net:80 (199.232.98.132), connection timed out Unable to connect to deb.debian.org:http:
34.24 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
------
ERROR: failed to solve: executor failed running [/bin/sh -c apt-get --allow-releaseinfo-change update &&     apt-get install -y wget]: exit code: 100
make[5]: *** [includes/sdk.mk:109: build-build-sdk-image] Error 1
make[5]: Leaving directory '/workspace/build'
make[4]: Leaving directory '/workspace/build'
make[4]: *** [includes/build-image.mk:63: ensure-image] Error 2
make[3]: *** [includes/sdk.mk:126: ensure-build-sdk-image] Error 2
make[3]: Leaving directory '/workspace/build'
Unable to find image 'agones-build-sdk-csharp:dbf73e956b' locally
docker: Error response from daemon: pull access denied for agones-build-sdk-csharp, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.
make[2]: *** [includes/sdk.mk:91: run-sdk-command] Error 125
make[2]: Leaving directory '/workspace/build'
make[1]: *** [includes/sdk.mk:87: run-sdk-command-csharp] Error 2
make[1]: Leaving directory '/workspace/build'
make: *** [includes/sdk.mk:239: test-gen-all-sdk-grpc] Error 2

gongmax avatar Feb 13 '24 17:02 gongmax

Build Succeeded :clap:

Build Id: 03e12482-1462-48d3-a138-3b52a193d4a9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://954cd1f-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3631/head:pr_3631 && git checkout pr_3631
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-954cd1f-amd64

agones-bot avatar Feb 13 '24 18:02 agones-bot

Build Succeeded :clap:

Build Id: e48caa8d-e3c2-40f8-bef9-97058efa8bac

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://63b3640-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3631/head:pr_3631 && git checkout pr_3631
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-63b3640-amd64

agones-bot avatar Feb 13 '24 20:02 agones-bot

Build Succeeded :clap:

Build Id: 713b3e1e-1b3b-470f-9801-b58ebd74360e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://63b3640-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3631/head:pr_3631 && git checkout pr_3631
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-63b3640-amd64

agones-bot avatar Feb 15 '24 03:02 agones-bot

Build Succeeded :clap:

Build Id: 62d29939-5812-45c9-81bf-220eb59399af

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://87071a8-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3631/head:pr_3631 && git checkout pr_3631
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-87071a8-amd64

agones-bot avatar Feb 15 '24 05:02 agones-bot

Just a note - this is approved, you can take it out of draft 😄

markmandel avatar Feb 20 '24 04:02 markmandel

Build Succeeded :clap:

Build Id: 1f78b3c0-acb5-423f-bf73-670c082fc4fa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://9b35dbf-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3631/head:pr_3631 && git checkout pr_3631
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-9b35dbf-amd64

agones-bot avatar Feb 20 '24 17:02 agones-bot