agones icon indicating copy to clipboard operation
agones copied to clipboard

Some info logs logged from sidecar when sdkServer.logLevel set to Error

Open steven-supersolid opened this issue 1 year ago • 0 comments

What happened: With sdkServer.logLevel set to Error sidecar logs are still visible such as

Starting sdk sidecar

And

Starting SDKServer grpc service...

What you expected to happen: To see only error logs from the sidecar

How to reproduce it (as minimally and precisely as possible):

  1. Set sdkServer.logLevel to Error via manifest entry
  2. Start a gs
  3. View logs and note that some info level logs are present

Anything else we need to know?: One log originates here https://github.com/googleforgames/agones/blob/main/cmd/sdk-server/main.go#L231 Another log originates here https://github.com/googleforgames/agones/blob/main/cmd/sdk-server/main.go#L75

These are triggered before logging is configured.

@markmandel posted that logging is configured here https://github.com/googleforgames/agones/blob/5f58fce4c00f97ef012db8f8a503898a4725d11b/pkg/sdkserver/sdkserver.go#L249C1-L261C3

Suggestion from Mark

Off the top of my head, I can't see any reason we couldn't make the log level an environment / arg on the sidecar pod instead, and have it be global

Environment:

  • Agones version: 1.32
  • Kubernetes version (use kubectl version): 1.26
  • Cloud provider or hardware configuration: GKE
  • Install method (yaml/helm): helm
  • Troubleshooting guide log(s):
  • Others:

steven-supersolid avatar Feb 02 '24 08:02 steven-supersolid