agones icon indicating copy to clipboard operation
agones copied to clipboard

Create an agones-dev user in the build docker images and map the user/group id to the host linux system

Open roberthbailey opened this issue 1 year ago • 7 comments

This fixes permission issues for files that are shared between the host and container, such as all of the common_mounts that are defined in the Makefile.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking /kind bug

/kind cleanup

/kind documentation /kind feature /kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

roberthbailey avatar May 29 '23 07:05 roberthbailey

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 29 '23 07:05 google-oss-prow[bot]

Build Failed :scream:

Build Id: 7d4c684b-f12d-4d17-b5c9-5aaf79260d8c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar May 29 '23 07:05 agones-bot

The error is:

docker build --tag=agones-build:6efc8db6ef /workspace/build//build-image \
	--build-arg USER_ID="0" \
	--build-arg GROUP_ID="0" \
...
 ---> Running in 6e465ad8ad5b
groupadd: GID '0' already exists

So my trick of making the new user use the same group & user id as the system may not work on cloudbuild because it seems to be running the scripts as the root user.

roberthbailey avatar May 30 '23 06:05 roberthbailey

Build Failed :scream:

Build Id: fcaeb492-0ea1-491c-976b-d2848af60191

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Jul 10 '23 08:07 agones-bot

Build Failed :scream:

Build Id: df218255-0159-4952-bcea-7ab81bdd496a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Jul 10 '23 09:07 agones-bot

Build Failed :scream:

Build Id: 4d631e26-aefa-441c-bbd6-3e3f7aeb10e3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Jul 10 '23 09:07 agones-bot

Build Failed :scream:

Build Id: 321bca59-6ec6-4db6-8c57-f65c26b35b44

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Jul 10 '23 09:07 agones-bot

Let's go ahead and close this for now, I'll fish out the changes if we need it.

zmerlynn avatar Mar 19 '24 17:03 zmerlynn