agones icon indicating copy to clipboard operation
agones copied to clipboard

Return ErrNoFleet state from Allocator service when the client requests a incorrect Fleet version

Open alvin-7 opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe. When a client requests a fleet that no longer exists, the allocator returns ErrNoGameServer, which makes it impossible to distinguish between the absence of a GameServer and an incorrect client Fleet version.

Describe the solution you'd like I hope to return the code error as ErrNoFleet.

Describe alternatives you've considered Returning the version error as ErrNoFleet will help the client understand that the version is incorrect and needs to be updated. Currently, ErrNoGameServer is being returned instead of an error message indicating the absence of the GameServer.

alvin-7 avatar Apr 18 '23 08:04 alvin-7

What if the request isn't for a Fleet - but just arbitrary labels? (ultimately, that is what an Allocation is - a selector for an arbitrary set of labels -- there just happens to be a standard label for a Fleet configuration).

markmandel avatar Apr 18 '23 08:04 markmandel

What if the request isn't for a Fleet - but just arbitrary labels? (ultimately, that is what an Allocation is - a selector for an arbitrary set of labels -- there just happens to be a standard label for a Fleet configuration).

Indeed, Agones currently offers only two types of game server roles: gameserver and fleet. Thus, I would like a more specific error message to be displayed when the label contains 'fleet'.(fleet label is unique and clear, so can do this)

alvin-7 avatar Apr 18 '23 09:04 alvin-7

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

github-actions[bot] avatar May 15 '24 10:05 github-actions[bot]

This issue is marked as obsolete due to inactivity for last 60 days. To avoid issue getting closed in next 30 days, please add a comment or add 'awaiting-maintainer' label. Thank you for your contributions

github-actions[bot] avatar Jun 15 '24 02:06 github-actions[bot]