agones icon indicating copy to clipboard operation
agones copied to clipboard

Published 20 hours ago • verified publisher icon googleforgames

Implemented PodDisruptionBudget on relevant deployments

Open valentintorikian opened this issue 2 years ago • 8 comments

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking /kind bug /kind cleanup /kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it: Added (optional) PodDisruptionBudget creation for the ping and allocator deployment. Disabled by default. Will allow for better management of voluntary disruptions.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

valentintorikian avatar Sep 14 '22 03:09 valentintorikian

Build Succeeded :clap:

Build Id: 509435e5-e37b-4c21-a44b-953204dc26b2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://5725210-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-5725210-amd64

agones-bot avatar Sep 14 '22 04:09 agones-bot

Thanks for the PR! I will take a look at it once the in-progress release is finalized (also, you will probably have to rebase and deal with conflicts in the documentation changes at that point).

roberthbailey avatar Sep 14 '22 04:09 roberthbailey

Build Succeeded :clap:

Build Id: 9f9325d1-9094-497f-9c40-760d1d8edb4d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://8ca4d02-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-8ca4d02-amd64

agones-bot avatar Sep 18 '22 17:09 agones-bot

Build Succeeded :clap:

Build Id: 9de7fb60-ffca-41e9-927b-85b51581ea61

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://454ade0-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-454ade0-amd64

agones-bot avatar Sep 18 '22 17:09 agones-bot

@valentintorikian - As expected, you now need to rebase your documentation changes.

roberthbailey avatar Sep 19 '22 05:09 roberthbailey

@roberthbailey rebased

valentintorikian avatar Sep 19 '22 14:09 valentintorikian

Build Succeeded :clap:

Build Id: 41e283be-ac80-41ea-9543-2c6456c75670

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://807468d-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-807468d-amd64

agones-bot avatar Sep 19 '22 14:09 agones-bot

@roberthbailey just gently bumping if this is good to go? Looks like you were reviewing 😃

markmandel avatar Sep 29 '22 20:09 markmandel

Build Succeeded :clap:

Build Id: e10468d0-5167-4688-91cc-6c0bade55422

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://f1df1bd-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-f1df1bd-amd64

agones-bot avatar Sep 30 '22 06:09 agones-bot

Just a gentle reminder that our Release Candidate comes out next week, so if you would like this in our next release, Tuesday next week is the deadline.

markmandel avatar Oct 10 '22 18:10 markmandel

Build Failed :scream:

Build Id: 3dd445f7-851d-442a-84d6-f33b068dc276

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Oct 14 '22 21:10 agones-bot

Build Succeeded :clap:

Build Id: 4ce81b70-be04-441a-8f14-6eee240e15b8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://f1df1bd-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-f1df1bd-amd64

agones-bot avatar Oct 14 '22 23:10 agones-bot

Build Succeeded :clap:

Build Id: 68990e16-e340-41db-85fc-3d7da364742b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://f1df1bd-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-f1df1bd-amd64

agones-bot avatar Oct 15 '22 00:10 agones-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: valentintorikian Once this PR has been reviewed and has the lgtm label, please assign pooneh-m for approval by writing /assign @pooneh-m in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Oct 22 '22 05:10 google-oss-prow[bot]

Build Succeeded :clap:

Build Id: 47000304-7854-4a68-9d75-626b078bce56

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://0894d7b-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-0894d7b-amd64

agones-bot avatar Oct 22 '22 05:10 agones-bot

Build Succeeded :clap:

Build Id: e40326e6-0fc9-4156-89d0-be92c08192a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://fd19f47-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-fd19f47-amd64

agones-bot avatar Nov 09 '22 06:11 agones-bot

@roberthbailey I'm happy to fix up the documentation on mutual-exclusivity after this goes in.

It looks like we could even use an approach like https://stackoverflow.com/questions/53508229/helm-chart-with-dependent-values to just ensure it.

zmerlynn avatar Nov 14 '22 17:11 zmerlynn

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, valentintorikian, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Nov 18 '22 09:11 google-oss-prow[bot]

Build Succeeded :clap:

Build Id: b062ad7a-4082-4a31-af8c-1caf1950a613

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://12f90ad-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2740/head:pr_2740 && git checkout pr_2740
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-12f90ad-amd64

agones-bot avatar Nov 18 '22 10:11 agones-bot