agones icon indicating copy to clipboard operation
agones copied to clipboard
verified publisher icon googleforgames

Clear metric labels on Fleet/Autoscaler delete

Open markmandel opened this issue 3 years ago • 4 comments

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup /kind documentation /kind feature /kind hotfix

What this PR does / Why we need it:

This introduces a new feature flag ResetMetricsOnDelete which when enabled, resets the appropriate metric views and revuilds them, thereby dropping labels for Fleets and/or Fleet Autoscalers when they get deleted.

Which issue(s) this PR fixes:

Closes #2478

Special notes for your reviewer:

markmandel avatar Aug 05 '22 19:08 markmandel

Build Succeeded :clap:

Build Id: bffb59b1-8a77-4313-9681-0f25c49b48df

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://14d30fb-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-14d30fb-amd64

agones-bot avatar Aug 05 '22 19:08 agones-bot

Build Failed :scream:

Build Id: ca65ce99-da33-47f5-a5fa-a12e5038c97e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Aug 08 '22 20:08 agones-bot

Caught by TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true in e2e-stable again.

me="2022-08-08 20:43:40.271" level=info msg="waiting for fleet condition" fleet=simple-fleet-1.0f7sz9 test="TestFleetRollingUpdate/Use_fleet_Patch_false_10%_cycle_false"
panic: Fail in goroutine after TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true has completed

goroutine 1792 [running]:
testing.(*common).Fail(0xc000901a00)
	/usr/local/go/src/testing/testing.go:710 +0x1b4
testing.(*common).Errorf(0xc00078d0c0, {0x216a601, 0x3}, {0xc00078d0b0, 0x1, 0x1})
	/usr/local/go/src/testing/testing.go:818 +0x85
github.com/stretchr/testify/assert.Fail({0x2410a80, 0xc000901a00}, {0xc000995620, 0x5f}, {0x0, 0x0, 0x0})
	/go/src/agones.dev/agones/vendor/github.com/stretchr/testify/assert/assertions.go:262 +0x43d
github.com/stretchr/testify/assert.NoError({0x2410a80, 0xc000901a00}, {0x240ff80, 0xc00074e640}, {0x0, 0x0, 0x0})
	/go/src/agones.dev/agones/vendor/github.com/stretchr/testify/assert/assertions.go:1332 +0x125
github.com/stretchr/testify/require.NoError({0x2429f28, 0xc000901a00}, {0x240ff80, 0xc00074e640}, {0x0, 0x0, 0x0})
	/go/src/agones.dev/agones/vendor/github.com/stretchr/testify/require/require.go:1231 +0xa5
agones.dev/agones/test/e2e/framework.(*Framework).CycleAllocations.func1.1(0xc0003b2b40)
	/go/src/agones.dev/agones/test/e2e/framework/framework.go:297 +0x1b4
created by agones.dev/agones/test/e2e/framework.(*Framework).CycleAllocations.func1
	/go/src/agones.dev/agones/test/e2e/framework/framework.go:294 +0x7e8
FAIL	agones.dev/agones/test/e2e	321.445s
FAIL
make[1]: *** [Makefile:306: test-e2e-integration] Error 1
make[1]: Leaving directory '/workspace/build'
make: *** [Makefile:297: test-e2e] Error 2

https://console.cloud.google.com/cloud-build/builds/ca65ce99-da33-47f5-a5fa-a12e5038c97e?project=258182270954

markmandel avatar Aug 08 '22 21:08 markmandel

Conflicts have been fixed!

markmandel avatar Aug 10 '22 17:08 markmandel

Build Succeeded :clap:

Build Id: 7c6f9d55-98b8-4029-b283-4a55590d363a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://b611113-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-b611113-amd64

agones-bot avatar Aug 10 '22 17:08 agones-bot

Gentle bump on review @roberthbailey 😄

markmandel avatar Aug 17 '22 18:08 markmandel

Build Succeeded :clap:

Build Id: 36731ecb-ece8-4b3b-b9bf-e130402e29b8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://54f85eb-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-54f85eb-amd64

agones-bot avatar Aug 24 '22 22:08 agones-bot

Build Succeeded :clap:

Build Id: 9d2b724f-8859-4892-b5f9-ea77fd345bb6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://8782d24-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-8782d24-amd64

agones-bot avatar Aug 25 '22 03:08 agones-bot

Build Succeeded :clap:

Build Id: adc788a7-a754-4da6-ab9a-1a54372d7778

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://3c63496-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-3c63496-amd64

agones-bot avatar Aug 30 '22 21:08 agones-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Sep 01 '22 21:09 google-oss-prow[bot]

New changes are detected. LGTM label has been removed.

google-oss-prow[bot] avatar Sep 01 '22 22:09 google-oss-prow[bot]

Build Succeeded :clap:

Build Id: 175dce8a-1178-4347-b9eb-865346d1ad80

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://580f8f4-dot-preview-dot-agones-images.appspot.com/

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2701/head:pr_2701 && git checkout pr_2701
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-580f8f4-amd64

agones-bot avatar Sep 01 '22 23:09 agones-bot