agones icon indicating copy to clipboard operation
agones copied to clipboard

Unity SDK should log API failures as errors, and log regardless of logEnabled

Open emrys90 opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. In production it seems like logEnabled should be set to false so you're not getting lots of debug logs. However, API errors are not logged without that enabled, and also they are logged as debug messages instead of using Debug.LogError.

Describe the solution you'd like I would like API failures to be logged using Debug.LogError, and to always be logged instead of conditionally.

Additional context I disabled the debug logging to not clutter the logs, but I had an Allocate API call fail. I have no information on why it failed since the errors aren't logged. So now I have to enable it and hope a repro case happens again to get this resolved in beta testing before releasing to production.

emrys90 avatar Mar 09 '22 23:03 emrys90

As an additional bit of info on this, it just happened again and here's what Agones logged: Agones SendRequest failed: /allocate Cannot connect to destination host

Any ideas what could be the issue? The API calls were working correctly a few seconds before the Allocate call

emrys90 avatar Mar 12 '22 21:03 emrys90

This sounds like a great improvement for the unity sdk. Would you be interested in sending a pull request to make the proposed changes?

roberthbailey avatar Mar 22 '22 18:03 roberthbailey

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

github-actions[bot] avatar Nov 15 '23 10:11 github-actions[bot]

This issue is marked as obsolete due to inactivity for last 60 days. To avoid issue getting closed in next 30 days, please add a comment or add 'awaiting-maintainer' label. Thank you for your contributions

github-actions[bot] avatar Jan 01 '24 02:01 github-actions[bot]