gftools icon indicating copy to clipboard operation
gftools copied to clipboard

[ufo-merge] are external (included) .fea files supported?

Open justvanrossum opened this issue 2 years ago • 5 comments

I seem to have trouble merging UFOs that include external feature files. Is that to be expected at this point?

justvanrossum avatar Aug 08 '22 17:08 justvanrossum

I think it should work. (although clearly it isn't for you!) If there's a minimal example I can have a look at it.

simoncozens avatar Aug 10 '22 10:08 simoncozens

I'll try to make an example, thank you. (I may have messed up, esp. since you say it should work.)

justvanrossum avatar Aug 10 '22 10:08 justvanrossum

Hm, it doesn't seem to flatten included .fea code, and merges the include statement as is.

The UFO in "merged" was made like this:

gftools ufo-merge FontA-Regular.ufo FontB-Regular.ufo -g "*" -o merged/Merged.ufo

The include reference in the merged font is no longer valid due to the different UFO location.

justvanrossum avatar Aug 10 '22 11:08 justvanrossum

Test files: merge_external_fea_test.zip

justvanrossum avatar Aug 10 '22 11:08 justvanrossum

Thanks, will take a look.

simoncozens avatar Aug 10 '22 11:08 simoncozens