gftools icon indicating copy to clipboard operation
gftools copied to clipboard

Don't kill MVAR table in fix-font

Open simoncozens opened this issue 2 years ago • 1 comments

We've re-thought the fontbakery check that complained about the MVAR table (https://github.com/googlefonts/fontbakery/issues/3400) but we still drop the MVAR table in fix-font. The problem with this is that fonts instantiated from a VF with no MVAR table have the wrong vertical metrics.

simoncozens avatar Jun 27 '22 09:06 simoncozens

I totally agree that we now shouldn't drop this table at all. However, we're still using browserstack which uses old browsers which are affected by the presence of an MVAR table. I plan to move us away from bstack and use github actions with headless chrome on a platform matrix in q3/q4, https://github.com/googlefonts/gftools/pull/420

Related https://github.com/googlefonts/fontbakery/issues/3413

m4rc1e avatar Jun 27 '22 09:06 m4rc1e