fontra icon indicating copy to clipboard operation
fontra copied to clipboard

Refactor shortcut logic to new module

Open justvanrossum opened this issue 11 months ago • 1 comments

The shortcut stuff is currently tied to editor.js, and we should somehow move that to a reusable place.

How about a new module at "core/shortcuts.js", providing support code for registering shortcut callbacks, and the key event handlers.

justvanrossum avatar Feb 27 '24 09:02 justvanrossum

At the same time I wonder if we should create a generic mechanism for menu callbacks and shortcuts to delegate to focused UI elements: so a menu item can work on different UI elements.

Perhaps our current menu callback en shortcut callback approach should be more integrated with each other. Food for thought.

justvanrossum avatar Feb 27 '24 09:02 justvanrossum

This was fixed by https://github.com/googlefonts/fontra/pull/1632.

justvanrossum avatar Sep 16 '24 18:09 justvanrossum