fontations icon indicating copy to clipboard operation
fontations copied to clipboard

Change IntSet::len() to return u64 instead of usize.

Open garretrieger opened this issue 1 year ago • 1 comments

A u32 containing intset can have up to u32::MAX + 1 elements in it which can overflow a usize when usize is a u32. Fixes #1057

garretrieger avatar Jul 30 '24 21:07 garretrieger

Once this lands, I'll submit a PR that improves the wasm32 CI job. (I was preparing to do that when I found this.)

waywardmonkeys avatar Aug 01 '24 04:08 waywardmonkeys

FWIW, in HarfBuzz we disallow inserting (unsigned) -1, and hence the population always fits in a uint32_t.

behdad avatar Aug 06 '24 19:08 behdad