diffenator2 icon indicating copy to clipboard operation
diffenator2 copied to clipboard

Downloading a GitHub release assumes the first asset is correct

Open RickyDaMa opened this issue 1 year ago • 1 comments

https://github.com/googlefonts/diffenator2/blob/7986b847c22a7591b3d307d252f053ff99aa90ab/src/diffenator2/utils.py#L57-L73

(line 72, the [0])

In a project I'm working on, this downloads the wrong release artifact, resulting in an error later on. When using the GitHub Action, there's currently no way to work around this

A couple of suggestions:

  1. Some kind of filtering support (both in diffenator2 and its GitHub action) or other means of selection
  2. For the GitHub action, log the name of the file being downloaded so this is easier to debug :)

I don't need an urgent fix, just thought it was worth having on the issue tracker!

RickyDaMa avatar Apr 10 '24 09:04 RickyDaMa

Thanks Ricky. I'll think of something.

m4rc1e avatar Apr 10 '24 16:04 m4rc1e