decovar icon indicating copy to clipboard operation
decovar copied to clipboard

Add build script

Open davelab6 opened this issue 7 years ago • 15 comments

https://github.com/TypeNetwork/fb-Decovar/blob/master/sources/2-build/Decovar.designspace exists but doesn't appear referenced in any build script (https://github.com/TypeNetwork/fb-Decovar/search?utf8=%E2%9C%93&q=Decovar.designspace&type=)

(Whereas in Amstelvar it is in https://github.com/TypeNetwork/fb-Amstelvar/blob/a879f3fbcc93826609e0d2bda6a90f0df0748cce/scripts/build.sh#L1)

davelab6 avatar Nov 13 '17 20:11 davelab6

I’ve added one similar to Amstelvar. https://github.com/TypeNetwork/fb-Decovar/pull/24

Note that this does not cover the manual addition of a STAT table. Hopefully this will be added to fonttools varLib soon, so maybe not worth building in yet?

djrrb avatar Nov 14 '17 16:11 djrrb

I guess just add a comment to the build script to show where the manual step occurs.... although AFAIK its like... you TTX the binary, copy the stat table into the directory with the right filename, patch the index TTX file, and re-run ttx on it to zip the XML back into the binary... so that seems scriptable

davelab6 avatar Nov 14 '17 20:11 davelab6

totally scriptable...do we need parity between amstelvar and decovar build processes? I would do this in python instead of a shell script...

djrrb avatar Nov 14 '17 21:11 djrrb

I don't need parity, I want a random type designer to be able to take the source files and reproduce the published binary with no fuss :) But that is rather ideal, and all that the contract requires is that you provide what you actually used to make your binary yourself, and adequate documentation for someone to reproduce what you did.

Section 15.2.2 provides more context if you want to nerd out on this stuff :) https://copyleft.org/guide/comprehensive-gpl-guidech16.html

davelab6 avatar Nov 14 '17 21:11 davelab6

So a python script is ok?

sberlow avatar Nov 14 '17 21:11 sberlow

So a python script is ok?

Absolutely! waf and SCons are the popular Python build systems, or you call roll your own in "make file style" (as in https://github.com/sphinx-doc/sphinx/issues/3196), or just have a simple imperative python script file...

davelab6 avatar Nov 14 '17 21:11 davelab6

i'll make something basic tomorrow and we can always add a build system around it...not very knowledgeable about these different approaches

djrrb avatar Nov 15 '17 00:11 djrrb

Thank you!! (Simple is good :)

On Nov 14, 2017 7:25 PM, "David Jonathan Ross" [email protected] wrote:

i'll make something basic tomorrow and we can always add a build system around it...not very knowledgeable about these different approaches

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TypeNetwork/fb-Decovar/issues/23#issuecomment-344445728, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9y7S8ndAcqZeIGGMVbVDc3hLH945mks5s2i9_gaJpZM4QcXw_ .

davelab6 avatar Nov 15 '17 01:11 davelab6

Well, the good news is that the latest fontTools now writes its own STAT table, so we no longer need to include a more complex build script to address it. :-)

The bad news is that the build script is finding some incompatibilities and not generating the VF as expected. So just wanted to let you know I’m still on top of automating the build process, but it might take a bit longer than expected, and the changes will affect the sources and not only the script itself.

djrrb avatar Nov 15 '17 13:11 djrrb

Ok cool, I appreciate you looking into it

On Nov 15, 2017 8:41 AM, "David Jonathan Ross" [email protected] wrote:

Well, the good news is that the latest fontTools now writes its own STAT table, so we no longer need to include a more complex build script to address it. :-)

The bad news is that the build script is finding some incompatibilities and not generating the VF as expected. So just wanted to let you know I’m still on top of automating the build process, but it might take a bit longer than expected, and the changes will affect the sources and not only the script itself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TypeNetwork/fb-Decovar/issues/23#issuecomment-344595281, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9y0wsjpzGDY5Gikc5yEmq26VpqsUMks5s2uoLgaJpZM4QcXw_ .

davelab6 avatar Nov 15 '17 13:11 davelab6

Change the sources?

Sent from my iPad

On Nov 15, 2017, at 8:41 AM, David Jonathan Ross [email protected] wrote:

Well, the good news is that the latest fontTools now writes its own STAT table, so we no longer need to include a more complex build script to address it. :-)

The bad news is that the build script is finding some incompatibilities and not generating the VF as expected. So just wanted to let you know I’m still on top of automating the build process, but it might take a bit longer than expected, and the changes will affect the sources and not only the script itself.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

dberlow avatar Nov 15 '17 14:11 dberlow

no design changes...just to make them compatible or whatever needs doing to get Decovar to build from source without manual intervention

djrrb avatar Nov 15 '17 14:11 djrrb

Who said design changes?;)

What I’m interested in are the source changes required for a style to properly build a stat table, if that is not already set up by nature and nurture in most fonts.

Decovar will always be an alien.

Sent from my iPad

On Nov 15, 2017, at 9:22 AM, David Jonathan Ross [email protected] wrote:

no design changes...just to make them compatible or whatever needs doing to get Decovar to build from source without manual intervention

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

dberlow avatar Nov 15 '17 14:11 dberlow

Haha ok good.

A basic STAT table is now being built by fontTools varLib (see commit here), so should now be included in all versions built with the latest fontTools.

There may be more source changes in store once more STAT-related data is specified in the designspace file (see discussion here)

djrrb avatar Nov 15 '17 14:11 djrrb

I think this is ready to roll, see #25. Please review, merge, and close if this looks good.

djrrb avatar Nov 18 '17 16:11 djrrb