android-kotlin-login icon indicating copy to clipboard operation
android-kotlin-login copied to clipboard

Rename const variable to SIGN_IN_RESULT_CODE

Open secretshardul opened this issue 4 years ago • 3 comments

The starter and finished code use a const variable SIGN_IN_RESULT_CODE. However this variable is incorrectly named as SIGN_IN_REQUEST_CODE in comments.

The Codelabs tutorial task 6: Implement the login button also used the name SIGN_IN_REQUEST_CODE. This should also be changed by maintainers.

Fixes #5 and #9

secretshardul avatar Jul 21 '20 17:07 secretshardul

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 21 '20 17:07 googlebot

@googlebot I signed it!

secretshardul avatar Jul 21 '20 17:07 secretshardul

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 21 '20 17:07 googlebot