core icon indicating copy to clipboard operation
core copied to clipboard

Cloud Robotics Core is incompatible with --incompatible_load_proto_rules_from_bzl

Open Yannic opened this issue 5 years ago • 2 comments

Hello maintainers of Cloud Robotics Core 👋,

The Bazel team is in progress of migrating the native Protobuf rules to Starlark. As a first step towards this goal, starting with Bazel 3.0, all Protobuf rules will require explicit load statements.

You can use the following buildifier command to apply most of the required migrations for you:

buildifier --lint=fix --warnings=native-proto $(find . -name "BUILD" -o -name "BUILD.bazel" -o -name "*.bzl")

For further information, see https://github.com/bazelbuild/bazel/issues/8922 or ping me.

Thanks, Yannic

Yannic avatar Dec 16 '19 22:12 Yannic

@Yannic, we depend on rules_go, which doesn't appear to have updated: https://github.com/bazelbuild/rules_go/issues/2266

If I understand correctly, it's impossible for us to be compliant until there is a compliant rules_go update available. Let me know if I'm mistaken.

drigz avatar Dec 18 '19 11:12 drigz

Yes, all (transitive) dependencies also need to become compliant for this repo to become fully compliant. I submitted a patch to https://github.com/bazelbuild/bazel-gazelle/pull/683 today, which makes go_repository compliant. When that PR is merged, I'll look into finishing https://github.com/bazelbuild/rules_go/pull/2315.

Yannic avatar Dec 18 '19 13:12 Yannic