nodejs-storage
nodejs-storage copied to clipboard
fix: make CreateBucketRequest extend from BucketMetadata to allow all…
… fields to be set
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
Fixes #2454 🦕
Making CreateBucketReqest extend BucketMetadata so that the missing fields that are accepted by https://cloud.google.com/storage/docs/json_api/v1/buckets/insert get carried over. I've left the custom fields alone as that would be a breaking change.
@danielduhh all tests are existing. Didn't make much sense to add unit tests to test each individual field is settable.