nodejs-storage icon indicating copy to clipboard operation
nodejs-storage copied to clipboard

`GetFilesResponse` not fully typed

Open jared-jewitt opened this issue 2 years ago • 1 comments

It would be nice to have more type definition for GetFilesResponse -- particularly for the second and third items in the tuple type.

The SDK docs don't specify that these two items exist; the only place I could find documentation about the response body (third item in the tuple) was the docs on the console.

Environment details

  • OS: MacOS Ventura 13.4.1
  • Node.js version: 16.10.0
  • npm version: 7.24.0
  • @google-cloud/storage version: 7.0.1

Steps to reproduce

  1. Observe the type definition for GetFilesResponse in node_modules
  2. Note that the second and third items in the tuple type are not fully typed

jared-jewitt avatar Aug 23 '23 20:08 jared-jewitt

Hi @jared-jewitt thanks for opening an issue. We are in the process of trying to cleanup a lot of these interfaces that weren't originally typed well / typed at all. Unfortunately, since more strongly typing things is potentially a breaking change this is something we will likely have to wait to release until the next major version.

ddelgrosso1 avatar Aug 24 '23 17:08 ddelgrosso1