nodejs-spanner icon indicating copy to clipboard operation
nodejs-spanner copied to clipboard

feat: (observability, samples): add tracing end-to-end sample

Open odeke-em opened this issue 1 year ago • 10 comments

This change documents an end-to-end observability tracing sample using OpenTelemetry, which then exports trace spans to Google Cloud Trace.

Updates #2079

odeke-em avatar Sep 27 '24 23:09 odeke-em

Warning: This pull request is touching the following templated files:

  • README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml
  • samples/README.md - samples/README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

No region tags are edited in this PR.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Sep 28 '24 06:09 snippet-bot[bot]

@surbhigarg92 @alkatrivedi @harshachinta kindly help me run the bots on this code, thank you!

odeke-em avatar Sep 28 '24 07:09 odeke-em

Kindly help me run the bots @surbhigarg92! Thank you.

odeke-em avatar Oct 03 '24 14:10 odeke-em

New samples should follow rubric format.

Refer: https://github.com/googleapis/nodejs-spanner/blob/main/samples/delete-backup-schedule.js

alkatrivedi avatar Oct 08 '24 06:10 alkatrivedi

@alkatrivedi observability includes traces and metrics. That rubric is behind Google Corp and my email isn't activated.

odeke-em avatar Oct 08 '24 06:10 odeke-em

@alkatrivedi sure let me tweak it look like that sample, thanks!

odeke-em avatar Oct 08 '24 07:10 odeke-em

@alkatrivedi kindly please take a look again, thank you!

odeke-em avatar Oct 08 '24 07:10 odeke-em

@odeke-em please add a test for the sample in https://github.com/googleapis/nodejs-spanner/blob/main/samples/system-test/spanner.test.js

alkatrivedi avatar Oct 08 '24 08:10 alkatrivedi

Done, thank you @alkatrivedi! Please take another look.

odeke-em avatar Oct 08 '24 09:10 odeke-em

@odeke-em Please also work on the github lint issues.

surbhigarg92 avatar Oct 29 '24 04:10 surbhigarg92