nodejs-firestore icon indicating copy to clipboard operation
nodejs-firestore copied to clipboard

feat: adding gcp resource name span attribute

Open Gautam04 opened this issue 1 month ago • 2 comments

Adding a new span attribute called gcp.resource.name which contains an identifier to a particular firestore database in the following format:

//firestore.googleapis.com/projects/{project}/databases/{database_id}

Example:

//firestore.googleapis.com/projects/my_project/databases/(default)

Gautam04 avatar Nov 30 '25 15:11 Gautam04

Googlers see b/437960147 and g/firestore-sdk-team/c/uvdOjkrQ2Ns/m/1wJrFyFdAwAJ for some background details

dconeybe avatar Dec 01 '25 19:12 dconeybe

It seems like this one is missing a test. Perhaps update https://github.com/googleapis/nodejs-firestore/blob/daa3d76a781faafa7de2f1fc7e144e620a98b110/dev/system-test/tracing.ts#L582.

MarkDuckworth avatar Dec 08 '25 16:12 MarkDuckworth

It seems like this one is missing a test. Perhaps update

https://github.com/googleapis/nodejs-firestore/blob/daa3d76a781faafa7de2f1fc7e144e620a98b110/dev/system-test/tracing.ts#L582

.

Have updated tests. Please check.

Gautam04 avatar Dec 14 '25 18:12 Gautam04

@MarkDuckworth @wu-hui Could you please review this PR?

Gautam04 avatar Dec 17 '25 17:12 Gautam04