feat: modernization part 2
This is a follow-up for these two PRs:
https://github.com/googleapis/nodejs-bigtable/pull/1739 https://github.com/googleapis/nodejs-bigtable/pull/1740
This takes care of some missing pieces that were discovered by further discussion:
- GcRuleBuilder is a more TypeScript-heavy way to validate ModifyColumnFamilies garbage collection rules, with type checking taking care of a lot of the constraints, and some minimal runtime checking for JavaScript users.
- Rather than raw GAPIC, the focus has shifted to selective GAPIC subclasses that can augment them. This is specifically done to assist with RestoreTable and waiting for table consistency.
- Data plane samples have been removed, as we don't want to encourage users to use them.
- Generated samples and tests have been auto-edited to use the selective GAPIC classes.
- Manual sample snippets have been updated to reflect the expected admin access and GcRuleBuilder usage.
There is still a CI issue that will need to be corrected before this can be merged. I don't think it's the result of this change, but I also don't want to chance it.
Here is the summary of changes.
You are about to delete 11 region tags.
-
samples/generated/v2/bigtable.check_and_mutate_row.js:28, tag
bigtable_v2_generated_Bigtable_CheckAndMutateRow_async -
samples/generated/v2/bigtable.execute_query.js:28, tag
bigtable_v2_generated_Bigtable_ExecuteQuery_async -
samples/generated/v2/bigtable.generate_initial_change_stream_partitions.js:28, tag
bigtable_v2_generated_Bigtable_GenerateInitialChangeStreamPartitions_async -
samples/generated/v2/bigtable.mutate_row.js:28, tag
bigtable_v2_generated_Bigtable_MutateRow_async -
samples/generated/v2/bigtable.mutate_rows.js:28, tag
bigtable_v2_generated_Bigtable_MutateRows_async -
samples/generated/v2/bigtable.ping_and_warm.js:28, tag
bigtable_v2_generated_Bigtable_PingAndWarm_async -
samples/generated/v2/bigtable.prepare_query.js:28, tag
bigtable_v2_generated_Bigtable_PrepareQuery_async -
samples/generated/v2/bigtable.read_change_stream.js:28, tag
bigtable_v2_generated_Bigtable_ReadChangeStream_async -
samples/generated/v2/bigtable.read_modify_write_row.js:28, tag
bigtable_v2_generated_Bigtable_ReadModifyWriteRow_async -
samples/generated/v2/bigtable.read_rows.js:28, tag
bigtable_v2_generated_Bigtable_ReadRows_async -
samples/generated/v2/bigtable.sample_row_keys.js:28, tag
bigtable_v2_generated_Bigtable_SampleRowKeys_async
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment
Warning: This pull request is touching the following templated files:
- README.md -
README.mdis managed bysynthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml
The CI is really not cooperating here (timeouts, quota errors, etc) but the code itself should be okay to review.