googleapis
System-test is not cleaning up instances properly
system-test failed to clean up test instances with not found errors like: Error: 5 NOT_FOUND: Failed to read: projects/{818418350420}/instances/gcloud-tests-d-inst-c089e871 which causes the test project to run out of node quota.
Is it throwing the error on a test and then as a result, not running one of the after hooks?
Also happens here: https://github.com/googleapis/nodejs-bigtable/issues/1099
Looking into this further, it looks like https://github.com/googleapis/nodejs-bigtable/blob/main/system-test/bigtable.ts#L110 should be cleaning up instances, but is not? Maybe we could always delete all existing instances before running tests? Maybe errors prevent the after hook from running?
I think now we rename the tests so that they include a date and we can find another mechanism for cleaning up leftover instances.
Due to a code change the instances were not being cleaned up because they were filtering on a prefix that didn't match the prefix of the instances being created. this PR ensures the prefix used for instance creation is the same as the prefix used when filtering for instance cleanup so that instances actually get cleaned up.